Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for per request timeout options. Fixes #562 #970

Merged
merged 1 commit into from
May 31, 2019

Conversation

meifans
Copy link
Contributor

@meifans meifans commented May 16, 2019

Adds support for per request timeout options
Fixes #562

Change:

  • Add Options UT
  • Ignore Options when set bodyIndex

As @kdavisk6 said

interface MyClient {
   @RequestLine("GET /data")
   public MyResponse getMyData(Request.Options options);
}

In Spring Cloud

interface MyClient {
   @RequestMapping(path = "/data")
   public MyResponse getMyData(Request.Options options);
}

* Add Options UT

* Ignore Options when set bodyIndex
Copy link
Member

@kdavisk6 kdavisk6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meifans

Thank you for taking the time to make this change and for working with us. Approved.

@kdavisk6 kdavisk6 added enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes labels May 28, 2019
@kdavisk6
Copy link
Member

@meifans

I've approved this PR and marked it "ready to merge" This indicated to any other contributors that, without any additional feedback, we will merge this request in a few days.

@kdavisk6 kdavisk6 added this to the 10.3.0 milestone May 28, 2019
@kdavisk6 kdavisk6 merged commit 23ee09e into OpenFeign:master May 31, 2019
@meifans meifans deleted the feature-562 branch June 3, 2019 09:47
velo pushed a commit to velo/feign that referenced this pull request Jun 30, 2019
…enFeign#970)

* Add Options UT

* Ignore Options when set bodyIndex
@kdavisk6 kdavisk6 modified the milestones: 10.3.0, 10.2.4 Jul 18, 2019
@eugeniyk
Copy link

eugeniyk commented Mar 4, 2023

Hey @kdavisk6, I think it's quite important feature to be reflected in the docs! WDYT?

Also is my understanding correct - there's no way to specify default timeouts per RequestLine?

In my vision client settings hierarchy should be like that

  1. request-level settings (has)
  2. endpoint-level settings (doesn't have, and that's were I struggle)
  3. client-instance-level settings (has)
  4. default client in current jvm settings (doesn't have, (3) is enough)
  5. defaults from feign repo (has)

velo pushed a commit that referenced this pull request Oct 7, 2024
* Add Options UT

* Ignore Options when set bodyIndex
velo pushed a commit that referenced this pull request Oct 8, 2024
* Add Options UT

* Ignore Options when set bodyIndex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per request timeout options
3 participants