Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/template unit test #958

Merged
merged 6 commits into from
May 8, 2019

Conversation

mstrYoda
Copy link
Contributor

@mstrYoda mstrYoda commented May 7, 2019

Added some unit tests for HeaderTemplate. Removed redundant identifiers from inner classes.

Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, but, travis is not happy about it

@velo velo added ready to merge Will be merged if no other member ask for changes waiting for feedback Issues waiting for a response from either to the author or other maintainers labels May 7, 2019
@mstrYoda
Copy link
Contributor Author

mstrYoda commented May 8, 2019

@velo I've fixed the travis build error.

@velo velo merged commit 03ff13e into OpenFeign:master May 8, 2019
@velo
Copy link
Member

velo commented May 8, 2019

All good, merged

@kdavisk6 kdavisk6 added this to the 10.2.1 milestone May 9, 2019
@kdavisk6 kdavisk6 removed ready to merge Will be merged if no other member ask for changes waiting for feedback Issues waiting for a response from either to the author or other maintainers labels May 11, 2019
velo pushed a commit to velo/feign that referenced this pull request Jun 30, 2019
* add HeaderTemplate create tests for fail

* - added expand test

* - remove redundant public static identifier from Retryer inner class

* - remove redundant public static identifier from Default inner class

* add license to test

* mvn clean install to format test file
velo pushed a commit that referenced this pull request Oct 7, 2024
* add HeaderTemplate create tests for fail

* - added expand test

* - remove redundant public static identifier from Retryer inner class

* - remove redundant public static identifier from Default inner class

* add license to test

* mvn clean install to format test file
velo pushed a commit that referenced this pull request Oct 8, 2024
* add HeaderTemplate create tests for fail

* - added expand test

* - remove redundant public static identifier from Retryer inner class

* - remove redundant public static identifier from Default inner class

* add license to test

* mvn clean install to format test file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants