Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Multiple Values for Consumes and Produces #765

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Adding Multiple Values for Consumes and Produces #765

merged 2 commits into from
Aug 14, 2018

Conversation

dangoslen
Copy link
Contributor

@dangoslen dangoslen commented Aug 13, 2018 •
edited
Loading

Addresses Issue #763

This PR adds the support for having multiple values in the @Produces and @Consumes annotations when using the JAXRSContract. Empty or null values are removed if present, and at least one non-empty or non-null value must be present.

To facilitate, I created a new method in Util that allows for removing values from an array that meet a Predicate criteria for removal.

@dangoslen dangoslen changed the title Addresses Issue #763 Adding Multiple Values for Consumes and Produces Aug 13, 2018
@velo velo added enhancement For recommending new capabilities waiting for votes Enhancements or changes proposed that need more support before consideration labels Aug 13, 2018
velo
velo approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I merge in 24 hours if nobody else asks for changes

@velo velo merged commit 6667b0f into OpenFeign:master Aug 14, 2018
@kdavisk6 kdavisk6 mentioned this pull request Aug 15, 2018
Closed
@carterkozak carterkozak mentioned this pull request Sep 28, 2018
Closed
velo pushed a commit that referenced this pull request Oct 7, 2024
@dangoslen @velo
Adding Multiple Values for Consumes and Produces (#765)
77c7ada 
* Adding multiple mediatype support for JaxRs contract

* Updating README for multiple values
velo pushed a commit that referenced this pull request Oct 8, 2024
@dangoslen @velo
Adding Multiple Values for Consumes and Produces (#765)
4851559 
* Adding multiple mediatype support for JaxRs contract

* Updating README for multiple values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo approved these changes

Assignees
No one assigned
Labels
enhancement For recommending new capabilities waiting for votes Enhancements or changes proposed that need more support before consideration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangoslen @velo