feat: Added decodeVoid feature #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
approved these changes
Jul 23, 2023
1 task
1 task
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* feat: Added decodeVoid feature * fix: Added decodeVoid for AsyncFeign --------- Co-authored-by: Marvin Froeder <[email protected]>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* feat: Added decodeVoid feature * fix: Added decodeVoid for AsyncFeign --------- Co-authored-by: Marvin Froeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
decodeVoid()feature, with which can be possible to change default behaviour of calling decoders for methods which has a void return type.Currently, if method has void return type, ResponseInterceptor or Decoder will not be called.
And this is good if you don't working with REST-less API which everytime returns 200 OK, and that response has a code parameter, using that, for example, I need to detect response was successful or not.
And I don't need to return any data from the method, because if method fails I will get exception, and I can avoid warnings from static analyzer about "ignored return value", if I would be changed void to Object to bypass this limitation.
I had idea about check the response in the Client wrapper, but then I would need to decode a JSON twice time in some cases.