Move responsibility for resolving RequestTemplateFactory #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wplong11
force-pushed
the
Extract-RequestTemplateFactoryResolver
branch
from
0f4d28d to
0392fe7
Compare
wplong11
changed the title
wplong11
changed the title
wplong11
force-pushed
the
Extract-RequestTemplateFactoryResolver
branch
from
0392fe7 to
e21d87d
Compare
wplong11
force-pushed
the
Extract-RequestTemplateFactoryResolver
branch
from
e21d87d to
157d4ed
Compare
wplong11
changed the title
wplong11
changed the title
wplong11
force-pushed
the
Extract-RequestTemplateFactoryResolver
branch
from
157d4ed to
e8c17e4
Compare
wplong11
changed the title
velo
approved these changes
Nov 22, 2022
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* Extract RequestTemplateFactoryResolver * Pass RequestTemplateFactoryResolver to MethodHandler.Factory * Remove buildTemplateFromArgs parameter from MethodHandler.Factory * Remove requestTemplateFactoryResolver parameter from ParseHandlersByName Co-authored-by: Marvin Froeder <[email protected]>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* Extract RequestTemplateFactoryResolver * Pass RequestTemplateFactoryResolver to MethodHandler.Factory * Remove buildTemplateFromArgs parameter from MethodHandler.Factory * Remove requestTemplateFactoryResolver parameter from ParseHandlersByName Co-authored-by: Marvin Froeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ParseHandlersByNametoMethodHandler.FactoryReview Guide