Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Test For Json Literals Being Passed as Header Values #1800

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Add Unit Test For Json Literals Being Passed as Header Values #1800

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de102fa
Add Unit Test For Json Literals Being Passed as Header Values
JKomoroski Oct 22, 2022
f9b226a
Merge branch 'master' into issue/1305/fix_json_literals
velo Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/src/test/java/feign/RequestTemplateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,17 @@ public void resolveTemplateWithHeaderWithEscapedCurlyBrace() {
.hasHeaders(entry("Encoded", Collections.singletonList("{{{{dont_expand_me}}")));
}

@Test
public void resolveTemplateWithHeaderContainingJsonLiteral() {
String json = "{\"A\":{\"B\":\"C\"}}";
RequestTemplate template = new RequestTemplate().method(HttpMethod.GET)
.header("A-Header", json);

template.resolve(new LinkedHashMap<>());
assertThat(template)
.hasHeaders(entry("A-Header", Collections.singletonList(json)));
}

@Test
public void resolveTemplateWithHeaderWithJson() {
String json = "{ \"string\": \"val\", \"string2\": \"this should not be truncated\"}";
Expand Down