Issue #1606 Customize the length of the body in FeignException builder #1767
Conversation
| return errorStatus(methodKey, response, null, null); | ||
| } | ||
| public static FeignException errorStatus(String methodKey, Response response, | ||
| Integer maxBodyBytesLength, Integer maxBodyCharsLength) { |
There was a problem hiding this comment.
This method is never invoked by feign.
So what would be the point of the change.
I'm sure I'm missing something
There was a problem hiding this comment.
@coungard what I'm not understanding is how.
That new method is never invoked by feign... how is that going to change anything?
There was a problem hiding this comment.
@velo if I'm right u mean Default implementation, where errorResponse() used:
, but i need custom decode() override implementation like this:
, where i can define body constraints - it's will be very helpfull.
There was a problem hiding this comment.
@velo the result can be clearly seen on the test -> FeignExceptionTest::lengthOfBodyExceptionTest (143)
There was a problem hiding this comment.
yeah, there is a test that invokes the new code. Where is the code the invokes this?!
As far I can tell, this change change behavior of a test, but no changes on feign behavior
There was a problem hiding this comment.
@velo Sorry, but isn't that enough? The code is called by Feign by default (null, null), but for us it will be overridden parameters:
#1767) Co-authored-by: Witalij Berdinskich <[email protected]> Co-authored-by: Marvin Froeder <[email protected]>
#1767) Co-authored-by: Witalij Berdinskich <[email protected]> Co-authored-by: Marvin Froeder <[email protected]>
No description provided.