Use charset of request to create the String content. #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
requested changes
Jan 30, 2022
| @@ -135,7 +135,12 @@ ClassicHttpRequest toClassicHttpRequest(Request request, Request.Options options | |||
| entity = new ByteArrayEntity(data, null); | |||
| } else { | |||
| final ContentType contentType = getContentType(request); | |||
| entity = new StringEntity(new String(data), contentType); | |||
| if (request.charset() != null) { | |||
| String content = new String(request.body(), request.charset()); | |||
There was a problem hiding this comment.
can we use data instead?
if not, need a comment explaining why need to use request.body()
| entity = new StringEntity(new String(data), contentType); | ||
| if (request.charset() != null) { | ||
| String content = new String(request.body(), request.charset()); | ||
| entity = new StringEntity(content, contentType); |
There was a problem hiding this comment.
can we move this line outside the if, and let the if block just handle the String content creation?!
|
Any chance of we having a unit test around this change? |
I don't know how to manipulate the request.charset() to return a changed encoding, and I don't know how to change the default for a single test. The issue happens if e.g. the client has default charset ISO_8859_1 and the server has UTF_8. |
velo
approved these changes
Mar 2, 2022
velo
added a commit
that referenced
this pull request
Oct 7, 2024
Co-authored-by: Marvin Froeder <[email protected]>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
Co-authored-by: Marvin Froeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1570