Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dangling javadoc comment warning for license header #1557

Closed
wants to merge 1 commit into from
Closed

Fixed dangling javadoc comment warning for license header #1557

wants to merge 1 commit into from

Conversation

Hakky54
Copy link
Contributor

@Hakky54 Hakky54 commented Dec 24, 2021

I was scrolling through the source code and I noticed a warning that the license header is marked as dangling javadoc comment I did some research and found out that the better way is to have a license header in the following format:

/*
 *
 */

Instead of:

/**
 *
 */

I don't think the existing header is incorrect formatted but my idea gave warnings and this was a way to resolve it. Not quite sure if you guys want this change. Because I change the format the copyright date needed to be updated to 2021 because of the maven license plugin scan. Looking to hear from you soon.

@velo
Copy link
Member

velo commented Jan 17, 2022

The PR ia massive and risk introducing unwanted changes.

If you want, just make the pom.xml change, and I will checkout the branch, apply license:format and push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants