Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated method. #1545

Merged
merged 6 commits into from
Jan 17, 2022
Merged

Remove deprecated method. #1545

merged 6 commits into from
Jan 17, 2022

Conversation

myifeng
Copy link
Contributor

@myifeng myifeng commented Dec 5, 2021

myifeng and others added 4 commits December 5, 2021 15:40
Replace JUnit ExpectedException with assertThrows.
Replace JUnit Assert.assertThat with TestCase.assertEquals.
Fix assertEquals parameter position.
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question...

Would love to move all assertions to assertJ or anything else

@myifeng
Copy link
Contributor Author

myifeng commented Dec 6, 2021

@velo I found these problems when I was looking for a solution for issue #1512 , and I just corrected it.

@velo velo merged commit 057caad into OpenFeign:master Jan 17, 2022
velo added a commit that referenced this pull request Oct 7, 2024
* Remove deprecated method.
Replace JUnit ExpectedException with assertThrows.
Replace JUnit Assert.assertThat with TestCase.assertEquals.
Fix assertEquals parameter position.

* Fix license

* format code

* Replace JUnit assertThat with Hamcrest.

* Replace TestCase.assertEquals with Assert.assertEquals

Co-authored-by: liqf7 <[email protected]>
Co-authored-by: Marvin Froeder <[email protected]>
velo added a commit that referenced this pull request Oct 8, 2024
* Remove deprecated method.
Replace JUnit ExpectedException with assertThrows.
Replace JUnit Assert.assertThat with TestCase.assertEquals.
Fix assertEquals parameter position.

* Fix license

* format code

* Replace JUnit assertThat with Hamcrest.

* Replace TestCase.assertEquals with Assert.assertEquals

Co-authored-by: liqf7 <[email protected]>
Co-authored-by: Marvin Froeder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants