-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated method. #1545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace JUnit ExpectedException with assertThrows. Replace JUnit Assert.assertThat with TestCase.assertEquals. Fix assertEquals parameter position.
velo
reviewed
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question...
Would love to move all assertions to assertJ or anything else
velo
approved these changes
Jan 17, 2022
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* Remove deprecated method. Replace JUnit ExpectedException with assertThrows. Replace JUnit Assert.assertThat with TestCase.assertEquals. Fix assertEquals parameter position. * Fix license * format code * Replace JUnit assertThat with Hamcrest. * Replace TestCase.assertEquals with Assert.assertEquals Co-authored-by: liqf7 <[email protected]> Co-authored-by: Marvin Froeder <[email protected]>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* Remove deprecated method. Replace JUnit ExpectedException with assertThrows. Replace JUnit Assert.assertThat with TestCase.assertEquals. Fix assertEquals parameter position. * Fix license * format code * Replace JUnit assertThat with Hamcrest. * Replace TestCase.assertEquals with Assert.assertEquals Co-authored-by: liqf7 <[email protected]> Co-authored-by: Marvin Froeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace JUnit ExpectedException with assertThrows.
Replace
org.junit.Assert.assertThat()
withorg.hamcrest.MatcherAssert.assertThat()
.Fix assertEquals parameter position.