-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide descriptions #34
feat: provide descriptions #34
Conversation
755586f
to
226b6d2
Compare
@JakobVogelsang I'm getting a lot of this in my unit tests:
I'd be very grateful if you could provide a small clue |
Ah, no forget it I discovered the cause 😉 |
226b6d2
to
d4f61ca
Compare
d4f61ca
to
c07fc28
Compare
@JakobVogelsang I would be most grateful for a review and happy to make improvements. The unit tests are running and passing except for some reason that escapes me they do not terminate - perhaps a missing brace somewhere. |
0aed63f
to
7db06d0
Compare
The cause of the unit tests not passing are the following tests in the dataset-element-editor.spec.ts file:
I'm not sure why they are not working |
318d1e5
to
5eeebb3
Compare
Closes #6