Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide descriptions #34

Conversation

danyill
Copy link

@danyill danyill commented Feb 7, 2025

Closes #6

@danyill danyill force-pushed the issue-6-provide-description-scoped-comp branch 2 times, most recently from 755586f to 226b6d2 Compare February 7, 2025 04:54
@danyill
Copy link
Author

danyill commented Feb 7, 2025

@JakobVogelsang I'm getting a lot of this in my unit tests:

🚧 Browser logs:
      Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information.
      TypeError: Illegal constructor
        at SampledValueControlElementEditor.attachShadow (node_modules/@open-wc/scoped-elements/html-element.js:74:25)
        at SampledValueControlElementEditor.createRenderRoot (node_modules/@open-wc/scoped-elements/lit-element.js:28:31)
        at SampledValueControlElementEditor.connectedCallback (node_modules/lit-element/node_modules/@lit/reactive-element/src/reactive-element.ts:1108:11)
        at SampledValueControlElementEditor.connectedCallback (node_modules/lit-element/src/lit-element.ts:187:10)
        at ChildPart._insert (node_modules/lit-html/src/lit-html.ts:1496:52)
        at ChildPart._commitNode (node_modules/lit-html/src/lit-html.ts:1540:35)
        at ChildPart._commitTemplateResult (node_modules/lit-html/src/lit-html.ts:1655:11)
        at ChildPart._$setValue (node_modules/lit-html/src/lit-html.ts:1469:11)
        at render (node_modules/lit-html/src/lit-html.ts:2269:7)
        at litFixtureSync (node_modules/@open-wc/testing-helpers/src/litFixture.js:32:3)

 ❌ Error: Uncaught TypeError: Illegal constructor (http://localhost:8000/node_modules/@open-wc/scoped-elements/html-element.js:74) 
      at ChildPart._insert (node_modules/lit-html/src/lit-html.ts:1496:52)
      at ChildPart._commitNode (node_modules/lit-html/src/lit-html.ts:1540:35)
      at ChildPart._commitTemplateResult (node_modules/lit-html/src/lit-html.ts:1655:11)
      at ChildPart._$setValue (node_modules/lit-html/src/lit-html.ts:1469:11)
      at render (node_modules/lit-html/src/lit-html.ts:2269:7)
      at litFixtureSync (node_modules/@open-wc/testing-helpers/src/litFixture.js:32:3)
      at litFixture (node_modules/@open-wc/testing-helpers/src/litFixture.js:63:14)
      at fixture (node_modules/@open-wc/testing-helpers/src/fixture-no-side-effect.js:62:12)
      at n.<anonymous> (editors/sampledvalue/sampled-value-control-element-editor.spec.ts:36:19)

I'd be very grateful if you could provide a small clue

@danyill
Copy link
Author

danyill commented Feb 7, 2025

Ah, no forget it I discovered the cause 😉

@danyill danyill force-pushed the issue-6-provide-description-scoped-comp branch from 226b6d2 to d4f61ca Compare February 7, 2025 05:14
@danyill danyill force-pushed the issue-6-provide-description-scoped-comp branch from d4f61ca to c07fc28 Compare February 7, 2025 09:41
@danyill danyill marked this pull request as ready for review February 7, 2025 10:03
@danyill
Copy link
Author

danyill commented Feb 7, 2025

@JakobVogelsang I would be most grateful for a review and happy to make improvements.

The unit tests are running and passing except for some reason that escapes me they do not terminate - perhaps a missing brace somewhere.

@danyill danyill force-pushed the issue-6-provide-description-scoped-comp branch from 0aed63f to 7db06d0 Compare February 7, 2025 19:13
@danyill
Copy link
Author

danyill commented Feb 7, 2025

The cause of the unit tests not passing are the following tests in the dataset-element-editor.spec.ts file:

 it('allows to move FCDA child one step up', async () => {
 it('allows to move FCDA child one step down', async () => {

I'm not sure why they are not working

@JakobVogelsang JakobVogelsang deleted the branch OpenEnergyTools:change-dependacies February 7, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants