Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing landscape classifications for SLE project #1991

Merged
merged 32 commits into from
Mar 6, 2025

Conversation

ColinHDev
Copy link
Member

@ColinHDev ColinHDev commented Dec 7, 2024

Summary of the discussion

For the SLE project, OEO concepts for multiple landscape classifications are needed, as described in #1962.

Type of change (CHANGELOG.md)

Add

  • Added legislation as a subclass of plan specification and 'has part' some 'target description'
    • definition: A legislation is a plan specification that is produced by a government and enables, prohibits or bans activities, or establishes rights or responsibilities.
  • Added ROG as an instance of legislation
    • definition: The ROG is a legislation providing the legal framework for spatial planning in Germany.
  • Added BNatSchG as an instance of legislation
    • definition: The BNatSchG is a legislation providing the legal framework for nature conservation and landscape management in Germany.

  • Added protected area role as a subclass of role
    • definition: A protected area role is a role of a region of relevance recognised, dedicated and managed through legal or other effective means, to achieve the long term conservation of nature with associated ecosystem services and cultural values.
  • Added Fauna Flora Habitat role as a subclass of protected area role and 'is defined by' value BNatSchG
    • definition: A Fauna Flora Habitat role is a protected area role for areas, aimed at conserving natural habitats and wild fauna and flora, within the European "Natura 2000" network of protected areas.
  • Added Bird Sanctuary role as a subclass of protected area role and 'is defined by' value BNatSchG
    • definition: A Bird Sanctuary role is a protected area role for areas, aimed at protecting and conserving endangered and migratory bird species, within the European "Natura 2000" network of protected areas.

  • Added Fauna Flora Habitat as an equivalent class of 'protected area' that 'has role' some 'Fauna Flora Habitat role'
    • definition: A Fauna Flora Habitat is a protected area that has the Fauna Flora Habitat role, aimed at conserving natural habitats and wild fauna and flora, within the European \"Natura 2000\" network of protected areas.
  • Added Bird Sanctuary as an equivalent class of 'protected area' that 'has role' some 'Bird Sanctuary role'
    • definition: A Bird Sanctuary is a protected area that has the Bird Sanctuary role, which is aimed at protecting and conserving endangered and migratory bird species, within the European "Natura 2000" network of protected areas.

Update

  • protected area
    • Moved from oeo-physical to oeo-model
    • Changed it from being a subclass of two-dimensional spatial region to being one of region of relevance
    • Added a subclass axiom: 'has role' some 'protected area role'
    • Updated its definition: A protected area is a region of relevance that has the protected area role.
  • conditionally reserved region role, priority region role, suitable region role
    • Added a subclass axiom: 'is defined by' value ROG

Remove

---

Workflow checklist

Automation

Closes #1962

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module labels Dec 7, 2024
@madbkr
Copy link
Contributor

madbkr commented Dec 12, 2024

I looked at what you did for a review - then I realized this should probably be a draft (instead of ready for review) since you still need to add changelog and term tracker.
Except that everything look fine!

@ColinHDev ColinHDev requested review from stap-m and madbkr December 13, 2024 18:00
@ColinHDev
Copy link
Member Author

The following changes were implemented, as discussed with @stap-m on Monday:

  • Split Natura 2000 role into Bird Sanctuary role and Fauna Flora Habitat role
  • Removed spatial legislation

I also added the term tracker annotation and the changelog.

Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing. Some suggestions for better readability.

@ColinHDev ColinHDev requested review from stap-m and madbkr February 6, 2025 08:23
@ColinHDev ColinHDev self-assigned this Mar 2, 2025
@ColinHDev ColinHDev force-pushed the feature-1962-landscape-classifications branch from 26dc6c9 to 903993c Compare March 2, 2025 16:31
@ColinHDev ColinHDev requested a review from stap-m March 2, 2025 16:57
@stap-m stap-m requested a review from LillyG901 March 3, 2025 10:10
@stap-m
Copy link
Contributor

stap-m commented Mar 4, 2025

This PR is already complex enough. I'd recommend to merge this after approval and not wait for #2006. If it gets too complex, it becomes be hard to review.

@stap-m
Copy link
Contributor

stap-m commented Mar 4, 2025

@ColinHDev can you please solve the conflicts and merge before the release

@ColinHDev ColinHDev merged commit 4bd27d6 into dev Mar 6, 2025
3 checks passed
@ColinHDev ColinHDev deleted the feature-1962-landscape-classifications branch March 6, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing landscape classifications for SLE project
3 participants