-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced more term tracker items with annotation #1850 #1923
replaced more term tracker items with annotation #1850 #1923
Conversation
We have owl files now, not omn files. Therefore, the replacement has to consider the prefixes as well. IAO has an obo prefix, but the new oeo class needs an oeo prefix, which is not there yet. @madbkr do you want to try fixing this or should we take a look together on monday? |
I replaced everything in 'oeo-shared-axioms.omn' now. |
As the OEO is imported as base, OEO entities should probably not have any prefix. |
Yes, for oeo-shared-axioms. |
Were all changes related to the term trackers done with a simple text editor and not with Protégé? Then it would be good to run the changes through Protégé that Protégé can do all the rearrangements. Else, future PR gets cluttered with rearrangements and the intentional changes of these future PRs get obfuscated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the owl files look fine and I assume Protégé does its job in the omn files properly.
So I approve this PR.
Summary of the discussion
This is a follow-up PR of #1922
See issue #1850
Type of change (CHANGELOG.md)
Update
Replaced missing term tracker item with term tracker annotation in
Workflow checklist
Automation
Closes #1850
PR-Assignee
term tracker item
Reviewer