Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced more term tracker items with annotation #1850 #1923

Merged

Conversation

madbkr
Copy link
Contributor

@madbkr madbkr commented Sep 18, 2024

Summary of the discussion

This is a follow-up PR of #1922
See issue #1850

Type of change (CHANGELOG.md)

Update

Replaced missing term tracker item with term tracker annotation in

  • oeo-import-edits.owl
  • oeo-physical-axioms.owl
  • oeo-shared-axioms.omn

Workflow checklist

Automation

Closes #1850

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@madbkr madbkr self-assigned this Sep 18, 2024
@github-actions github-actions bot added the oeo-shared changes the oeo-shared module label Sep 18, 2024
@madbkr madbkr marked this pull request as ready for review September 18, 2024 08:03
@madbkr madbkr changed the title replaced more term tracker items with annotation replaced more term tracker items with annotation #1850 Sep 18, 2024
@l-emele
Copy link
Contributor

l-emele commented Sep 18, 2024

In oeo-shared-axioms.omn there are also a couple of term tracker item left.
grafik

@stap-m
Copy link
Contributor

stap-m commented Sep 18, 2024

grafik

We have owl files now, not omn files. Therefore, the replacement has to consider the prefixes as well. IAO has an obo prefix, but the new oeo class needs an oeo prefix, which is not there yet. @madbkr do you want to try fixing this or should we take a look together on monday?

@madbkr
Copy link
Contributor Author

madbkr commented Sep 18, 2024

I replaced everything in 'oeo-shared-axioms.omn' now.
I also tried to fix the prefixed by replacing obo:OEO_00020426 with oeo:OEO_00020426. But since a check failed this obviously didn't work as planned.
So yes, I'd be happy to look at it on monday. @stap-m
Maybe oeo:OEO_00020426 is missing a declaration?

@l-emele
Copy link
Contributor

l-emele commented Sep 18, 2024

I also tried to fix the prefixed by replacing obo:OEO_00020426 with oeo:OEO_00020426. But since a check failed this obviously didn't work as planned.

As the OEO is imported as base, OEO entities should probably not have any prefix.

@stap-m
Copy link
Contributor

stap-m commented Sep 18, 2024

As the OEO is imported as base, OEO entities should probably not have any prefix.

Yes, for oeo-shared-axioms.
For oeo-import-edits we need an oeo prefix, I guess.
EDIT: and as well for oeo-physical-axioms.

@l-emele
Copy link
Contributor

l-emele commented Sep 19, 2024

Were all changes related to the term trackers done with a simple text editor and not with Protégé? Then it would be good to run the changes through Protégé that Protégé can do all the rearrangements.

Else, future PR gets cluttered with rearrangements and the intentional changes of these future PRs get obfuscated.

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-sector oeo-social changes the oeo-social module labels Sep 19, 2024
@stap-m stap-m requested a review from l-emele September 19, 2024 09:35
@stap-m
Copy link
Contributor

stap-m commented Sep 19, 2024

@madbkr We have a release planned for Tuesday and there are some PRs waiting for these changes, therefore I declared the prefixes and made protege rearrange the files by minor changes.
I'll now review.
@l-emele can you please also review?

Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the owl files look fine and I assume Protégé does its job in the omn files properly.
So I approve this PR.

@stap-m stap-m merged commit fbeee7d into dev Sep 19, 2024
4 checks passed
@l-emele l-emele deleted the feature-1850-replaced-more-term-tracker-item-with-annotation branch September 26, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-sector oeo-shared changes the oeo-shared module oeo-shared-axioms oeo-social changes the oeo-social module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reconsidering the usage of term tracker item
3 participants