add slope + azimuth surface angle #1087

[markus-rothkoetter]

Related discussions

This PR closes #1087.

Aspects to be addressed

Type of Change	Aspect	Reference
[A__]	slope	💬
➕ Axiom	has unit some plane angle unit
[A__]	surface azimuth angle	💬
➕ Axiom	has unit some plane angle unit

[l-emele]

I don't understand why this PR is now open for more than a week. The issue seems pretty straight forward.

I'm still looking for the right location where to place the changes in the ontology

If you mean the right module: it is clearly oeo-physical.

[markus-rothkoetter]

Thank you for indicating the oeo-physical module.
I was rather looking for the BFO class (which seems to be quality for me).
Things that seem to be obvious might be a bumpy road for newbies.

While focusing on the bug fix for inversing the object properties (another PR), I postponed working on this one.
In the future, I'll refrain from opening drafts too early ;)

[l-emele]

I was rather looking for the BFO class (which seems to be quality for me). Things that seem to be obvious might be a bumpy road for newbies.

The definitions of both slope and surface azimuth angle say ... is a quantity value that..., so the parent class is quantity value.

While focusing on the bug fix for inversing the object properties (another PR), I postponed working on this one. PIn the future, I'll refrain from opening drafts too early ;)

Probably it is not the best idea to work on too many implementations in parallel.

[markus-rothkoetter]

While working on OEO_00000350 aka quality value, I noticed some strangly rendering term tracker item entries in Protégé:

Those seem to be introduced in #810, as if placing the term tracker item in the file has gone wrong.
@l-emele Is there a specific reason to add the term tracker item like this?
Editing the specific entry from Protégé is blocked and can only be done via an editor.

This is unrelated to the review, but worth mentioning in my opinion.

[l-emele]

That is not a bug, but a feature. The term tracker in this case does not apply to the whole class but only to one annotation property. It can be edited via the @ button:

[l-emele]

Looks fine and thus I approve.

[markus-rothkoetter]

That is not a bug, but a feature. The term tracker in this case does not apply to the whole class but only to one annotation property. It can be edited via the @ button:

Thanks, haven't been aware of this functionality.