Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add potential as parent class #1093 #1102

Merged
merged 15 commits into from
May 3, 2022
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Here is a template for new release sections
- import price, export price (#1083)
- personal living space (#1084)
- data / copyright / software license, has copyright license (#1090)
- potential (#1102)

### Changed
- has bearer, bearer of, is defined by, process attribute of (#985)
Expand All @@ -34,6 +35,7 @@ Here is a template for new release sections
- starts, starts with, located in, location of, ends, ends with, part of, has part (#1086)
- acronym (#1075)
- space requirement (#1084)
- flow potential, stock potential (#1102)
- energy, has role (#1101)
- greenhouse gas emission (#1100)
- water (#1099)
Expand Down
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ by [Vincent Driessen](https://nvie.com/posts/a-successful-git-branching-model/).
git add [file_name]
```

**🔎 Quick Tip:**
Changes in `catalog.xml`-files do NOT have to be staged, UNLESS something in the file structure has changed (e.g. adding/rearranging files, [see 🔗](https://github.com/OpenEnergyPlatform/ontology/pull/1102#issuecomment-1090003565))

commit your changes
```bash
git commit [-m " <commit_message> "]
Expand Down
35 changes: 29 additions & 6 deletions src/ontology/edits/oeo-physical.omn
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,18 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1027",
(<http://openenergy-platform.org/ontology/oeo/oeo-physical/OEO_00010244> or (not (OEO_00010032)))


Class: <http://openenergy-platform.org/ontology/oeo/oeo-physical/OEO_00290000>

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "A potential is a quantity value that describes some upper limit in a spatial region of reference.",
<http://purl.obolibrary.org/obo/IAO_0000233> "issue: https://github.com/OpenEnergyPlatform/ontology/issues/1093
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1102",
rdfs:label "potential"@en

SubClassOf:
OEO_00000350


Class: <http://purl.obolibrary.org/obo/BFO_0000002>


Expand Down Expand Up @@ -3250,6 +3262,9 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/766"

Class: OEO_00000350

SubClassOf:
<http://purl.obolibrary.org/obo/IAO_0000136> some <http://purl.obolibrary.org/obo/BFO_0000006>


Class: OEO_00000356

Expand Down Expand Up @@ -6956,13 +6971,17 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/591",
Class: OEO_00140056

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "A flow potential is a quantity value that describes the upper limit of an input or output of a process in a spatial region of reference per unit time.",
<http://purl.obolibrary.org/obo/IAO_0000115> "A flow potential is a potential of an input or output of a process, per time unit.",
<http://purl.obolibrary.org/obo/IAO_0000233> "issue: https://github.com/OpenEnergyPlatform/ontology/issues/481
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/607",
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/607

change: adjust definition to be based on parent class
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1093
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1102",
rdfs:label "flow potential"@en

SubClassOf:
OEO_00000350
OEO_00290000


Class: OEO_00140057
Expand Down Expand Up @@ -7028,13 +7047,17 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/607",
Class: OEO_00140062

Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "A stock potential is a quantity value that describes the upper limit of a stock of a source or sink in a spatial region of reference.",
<http://purl.obolibrary.org/obo/IAO_0000115> "A stock potential is a potential of the stock of a source or sink.",
<http://purl.obolibrary.org/obo/IAO_0000233> "issue: https://github.com/OpenEnergyPlatform/ontology/issues/481
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/607",
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/607

change: adjust definition to be based on parent class
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1093
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1102",
rdfs:label "stock potential"@en

SubClassOf:
OEO_00000350
OEO_00290000


Class: OEO_00140063
Expand Down