Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure and improve wiki #1106

Closed
6 of 13 tasks
markus-rothkoetter opened this issue Apr 7, 2022 · 8 comments
Closed
6 of 13 tasks

Restructure and improve wiki #1106

markus-rothkoetter opened this issue Apr 7, 2022 · 8 comments
Assignees
Labels
meta issue Issue that collects information about topics and will be closed after detailled issues are solved. organisation Concerning the repository and GitHub related tasks wiki about adding or editing the wiki

Comments

@markus-rothkoetter
Copy link
Contributor

markus-rothkoetter commented Apr 7, 2022

Description of the issue

The current wiki contains some work-in-progress pages as well as bugs like broken links etc.
I'd like to improve and standardise the wiki.

This issue is meant to be a collection of aspects to address (bugs, ideas, comments, ...)
As soon as an aspects gets concrete I think it's best to open a dedicated issue.

  • 🐙 links to issue
  • 📚 links to wiki-page
  • 💬 links to comments in this issue, which introduce the aspect

I'll keep the lists in this issue description up-to-date.
🚀 reactions on comments, indicate that I added the aspect to the list.

Aspects to address NOW 🦾

Things that are planned to be done now.

  • add "wiki-workflow" page

Aspects to address IN THE FUTURE ⏳

Things that are NOT prioritised, yet, or are NOT outlined concretely.

  • fix broken links in wiki sidebar
  • add 🤖 script for diffs
  • extend BFO description (tree-view)
  • separate extensive sections from CONTRIBUTING.md and include these in the wiki
  • remove redundant TOC-pages / deep nesting (decreases maintenance effort)
  • refactor short subpages 💬

Aspects resolved IN THE PAST 🎉

Things that are already done.

  • add module import script description 📚 Wiki | 🏁 @2022-08-30
  • create add basic WIP-banner
  • add pull-request workflow page
  • add ROBOT to 📚 Wiki | 🏁@2022-04-19
  • add page "add yourself as contributor" to 📚 Wiki | 🏁@2022-05-03
  • refine content in "pull-request-workflow" (📚 Wiki | 🏁@2022-05-09
@markus-rothkoetter markus-rothkoetter added organisation Concerning the repository and GitHub related tasks To do Issues that haven't got discussed yet wiki about adding or editing the wiki labels Apr 7, 2022
@markus-rothkoetter markus-rothkoetter self-assigned this Apr 7, 2022
@l-emele
Copy link
Contributor

l-emele commented Apr 8, 2022

Some wiki pages are very short, e.g. the subpages on the use cases: https://github.com/OpenEnergyPlatform/ontology/wiki/use-cases . I think, those very short pages that only include of one or two sentences should be included in other pages.

@stap-m stap-m added this to the oeo-release-1.10.0 milestone Apr 25, 2022
@stap-m
Copy link
Contributor

stap-m commented Apr 25, 2022

Can this be implemented (partly) before the next release?

@markus-rothkoetter
Copy link
Contributor Author

Things in the NOW-section: ✔Yes :)
I'll address these, after I'm done with the two/three PRs (issues) I'm currently assigned.

IN THE FUTURE-section things: Not before the next release.

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Apr 25, 2022
@l-emele
Copy link
Contributor

l-emele commented May 9, 2022

I only had today the chance to look into the changes of the wiki. The idea was to improve the wiki and not do introduce completely new workflows. Workflow changes should be discussed beforehand. Therefore e.g. I changed on the page https://github.com/OpenEnergyPlatform/ontology/wiki/Supplementary-Checklists that the persons that are involved in the issues are the ones who should review a PR.

Additionally, I think, the usage of emojis in the write place can be helpful. But scattering everything with emojis is at least for me very distracting and makes things hard to read.

@markus-rothkoetter
Copy link
Contributor Author

Additionally, I think, the usage of emojis in the write place can be helpful. But scattering everything with emojis is at least for me very distracting and makes things hard to read.

No problem. I adopted the Emoji-Style from the CONTRIBUTING.md, and added some additional ones where I thought it might be appropriate. I'll remove the additional ones. Thank you for the input!

.... not do introduce completely new workflows. Workflow changes should be discussed beforehand.

I absolutely agree on dicussing workflows first. So, I did not introduce a new workflow except for the "Reviewer-perspective".
Especially, the example you mentioned is listed in the current CONTRIBUTING.md as no. 11 under "Review"-section.

Maybe we can think about a short meeting that we can have a look at the current documentation, so that you can comment on their up-to-dateness?

@stale stale bot added the stale already discussed issues that haven't got worked on for a while label May 25, 2022
@stap-m stap-m removed this from the oeo-release-1.11.0 milestone Jun 30, 2022
@stap-m stap-m added the meta issue Issue that collects information about topics and will be closed after detailled issues are solved. label Jun 30, 2022
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Jun 30, 2022
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Jul 30, 2022
@markus-rothkoetter markus-rothkoetter removed their assignment Aug 30, 2022
@Alex2448
Copy link
Contributor

Alex2448 commented Nov 1, 2022

I think it is a good idea to mention in the PR-Guideline to wait for a second review if the PR is too large (maybe set a rule for >100 lines or if many concepts are introduced).

Also, sometimes there are some things decided that I did not know and did not follow where to find it. For example, to not use the language @en annotation for labels or definitions . I think this should be mentioned in how to add annotations to a class or how to use protégé since sometimes protégé automatically adds them.

@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Nov 1, 2022
@stap-m
Copy link
Contributor

stap-m commented Nov 1, 2022

I think it is a good idea to mention in the PR-Guideline to wait for a second review if the PR is too large (maybe set a rule for >100 lines or if many concepts are introduced).

I just saw, that Contributing.md is also ambiguous here and should be clarified aswell.

@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Nov 22, 2022
@stap-m stap-m added this to the oeo-release-1.15.0 milestone Mar 28, 2023
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Mar 28, 2023
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Apr 26, 2023
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label May 17, 2023
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Jun 10, 2023
@stale stale bot removed stale already discussed issues that haven't got worked on for a while labels Aug 1, 2023
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Sep 17, 2023
@stale stale bot removed stale already discussed issues that haven't got worked on for a while labels Nov 21, 2023
@stap-m
Copy link
Contributor

stap-m commented Dec 2, 2024

This has been done by @madbkr

@stap-m stap-m closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta issue Issue that collects information about topics and will be closed after detailled issues are solved. organisation Concerning the repository and GitHub related tasks wiki about adding or editing the wiki
Projects
None yet
Development

No branches or pull requests

8 participants