-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OMI omits null
values from json during processing
#71
Labels
type: enhancement ⚙️
Improvement of an existing feature
Comments
chrwm
added a commit
that referenced
this issue
Oct 31, 2022
With changing to False, metadata json keys and values will remain in the metadata as `null` after processing with omi.
jh-RLI
added a commit
that referenced
this issue
Jan 19, 2024
jh-RLI
added a commit
that referenced
this issue
Jan 19, 2024
jh-RLI
added a commit
that referenced
this issue
Jan 19, 2024
jh-RLI
added a commit
that referenced
this issue
Jan 19, 2024
…s omit the none value from json because the static test structures used to compare the results also do not include nones / nulls #71
jh-RLI
added a commit
that referenced
this issue
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When omi processes json metadata it omits values and metadata that are
null
.This is due when omi reads a json into a python dict,
null
is read in asNone
. This results in missing metadata fields when compiling with omi.e.g. missing description field and unit field
input
output
This is important as oem2orm throughs an error for some keys when generating tables from metadata for the OEP and they're missing, e.g. description.
The current status makes automatic metadata processing and upload impracticable.
EDIT
After implementing omit_none=False results
output
The text was updated successfully, but these errors were encountered: