Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenario bundles: a never-ending progress loop, when creating a bundle if the use is not logged in #1586

Closed
1 task
adelmemariani opened this issue Feb 14, 2024 · 1 comment · Fixed by #1595 or #1598
Closed
1 task

Scenario bundles: a never-ending progress loop, when creating a bundle if the use is not logged in #1586

adelmemariani opened this issue Feb 14, 2024 · 1 comment · Fixed by #1595 or #1598
Assignees
@adelmemariani
Labels
bug Scenario Bundle Feature of the oeplatform. Urgency-L urgency level: large

Comments

@adelmemariani
Copy link
Contributor

adelmemariani commented Feb 14, 2024 •
edited
Loading

Currently, if the user is not logged in, a never-ending progress appears when the save button is clicked.

Ideas of solution

Disable the "create new" button if the user is not logged in. Guide the user to the login page.

Workflow checklist
@adelmemariani adelmemariani added bug Urgency-L urgency level: large labels Feb 14, 2024
@adelmemariani adelmemariani self-assigned this Feb 14, 2024
@jh-RLI jh-RLI added the Scenario Bundle Feature of the oeplatform. label Feb 16, 2024
@jh-RLI jh-RLI mentioned this issue Feb 18, 2024
Closed
1 task
jh-RLI added a commit that referenced this issue Feb 18, 2024
@jh-RLI
on create_factsheet remove login_required and send 403 in case user i…
d8c091d 
…s not logged in to ease error handling in frontend #1586 #1587

- formatting
jh-RLI added a commit that referenced this issue Feb 18, 2024
@jh-RLI
catch error in case user not logged in and 403 response is present ->…
fd4f0d7 
… redirect to login page #1586
@jh-RLI jh-RLI mentioned this issue Feb 18, 2024
Merged
5 tasks
jh-RLI added a commit that referenced this issue Feb 18, 2024
@jh-RLI
update changelog #1586
543786c
@jh-RLI
Copy link
Contributor

jh-RLI commented Feb 18, 2024

Fixed. We still shoud prevent users from opening the "Create New" page completely.

adelmemariani added a commit that referenced this issue Feb 19, 2024
@adelmemariani
Disable create new button when the user is not logged in #1587 #1586
5880019
adelmemariani added a commit that referenced this issue Feb 19, 2024
@adelmemariani
update changelog #1587 #1586
50eae78
@adelmemariani adelmemariani mentioned this issue Feb 19, 2024
Merged
5 tasks
jh-RLI added a commit that referenced this issue Feb 19, 2024
@jh-RLI
Merge pull request #1598 from OpenEnergyPlatform/feature-1586-disable…
8ab6765 
…-create-new-if-not-logged-in

Disable create new button when the user is not logged in #1587 #1586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adelmemariani adelmemariani

Labels
bug Scenario Bundle Feature of the oeplatform. Urgency-L urgency level: large
Projects
None yet
Milestone
No milestone
2 participants
@adelmemariani @jh-RLI