Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing context properties & introduce scoped context for temporal and spatial fields #260

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Add missing context properties & introduce scoped context for temporal and spatial fields #260

merged 4 commits into from
Feb 13, 2025

Conversation

jh-RLI
Copy link
Contributor

@jh-RLI jh-RLI commented Feb 12, 2025 •
edited
Loading

Summary of the discussion

Fix issues in json ld context see #259.

Type of change (CHANGELOG.md)

Changed

  • Fix bug in JSON-LD context related to properties: resource, languages, resolutionValue & introduce scoped context for spatial and temporal objects to properly annotate resolutionValue in both objects (#260)

Workflow checklist

Automation

Closes #259

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@jh-RLI jh-RLI self-assigned this Feb 12, 2025
@jh-RLI jh-RLI requested a review from Ludee February 12, 2025 12:17
Ludee
Ludee approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@Ludee Ludee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ludee Ludee added type: bug 🐛 Something isn't working priority: critical 🔥 Critical priority part: backend 🧱 Backend component status: completed ✔️ Task has been completed labels Feb 13, 2025
@jh-RLI jh-RLI merged commit b69fc26 into develop Feb 13, 2025
3 checks passed
@jh-RLI jh-RLI deleted the bugfix-259-add-missing-context branch February 13, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ludee Ludee Ludee approved these changes

Assignees

@jh-RLI jh-RLI

Labels
part: backend 🧱 Backend component priority: critical 🔥 Critical priority status: completed ✔️ Task has been completed type: bug 🐛 Something isn't working
Projects
OEMetadata v2.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some properties are missing in the json-ld contect
2 participants
@jh-RLI @Ludee