Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new user #252 #253 #255

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Add new user #252 #253 #255

merged 4 commits into from
Feb 6, 2025

Conversation

Ludee
Copy link
Member

@Ludee Ludee commented Feb 3, 2025

Summary of the discussion

Add new user.

Type of change (CHANGELOG.md)

Added

Workflow checklist

Automation

Closes #252
Closes #253

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee added type: enhancement ⚙️ Improvement of an existing feature part: community 🌍 Concerns the community or outreach priority: critical 🔥 Critical priority status: completed ✔️ Task has been completed labels Feb 3, 2025
@Ludee Ludee requested a review from jh-RLI February 3, 2025 19:30
@Ludee Ludee self-assigned this Feb 3, 2025
@Ludee Ludee marked this pull request as ready for review February 3, 2025 19:32
alias: ""
affiliation: ""
orcid: "https://orcid.org/"
comment: "https://"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the comment means here ? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the comment to add a link to the source where the package has been used or implemented.
It now serves as a list of references and users.

Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above is still relevant but in general this is great,

@Ludee Ludee merged commit 1dd9f56 into develop Feb 6, 2025
3 checks passed
@Ludee Ludee deleted the enhance-252-users branch February 6, 2025 12:10
@Ludee Ludee removed the priority: critical 🔥 Critical priority label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: community 🌍 Concerns the community or outreach status: completed ✔️ Task has been completed type: enhancement ⚙️ Improvement of an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add new user to USERS.cff Add new user to USERS.cff
2 participants