Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Log warning for invalid JSON Schema in which "properties" values aren't JSON Schema #71

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Conversation

jpmckinney
Copy link
Contributor

Fixes recent Sentry errors in cove-ocds and kingfisher-process.

Occurs because an MTender extension does:

    "ValueDifference": {
      "title": "",
      "description": "",
      "type": "object",
      "properties": {
        "value": "",
        "unit": {
          "$ref": "#/definitions/Unit"
        }
      },
      "extension": "eAuction"
    },

value can't be a string. It must be a JSON Schema.

Problem is in https://raw.githubusercontent.com/eOCDS-Extensions/eOCDS-eAuction/master/release-schema.json

cc @duncandewhurst

@jpmckinney jpmckinney changed the title common: Log error for invalid JSON Schema in which "properties" values aren't JSON Schema common: Log warning for invalid JSON Schema in which "properties" values aren't JSON Schema Oct 29, 2020
@duncandewhurst duncandewhurst requested a review from Bjwebb October 29, 2020 21:17
@Bjwebb Bjwebb merged commit a3a321c into OpenDataServices:master Nov 4, 2020
@jpmckinney jpmckinney deleted the fix-mtender-schema-bug branch November 10, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants