Fix: Descend into nullable objects and arrays #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmckinney
changed the title
For example, OCDS `parties/details` is nullable, and additional codes for `parties/details/scale` were unreported.
|
Do you have any simple sample data handy we can turn into a test? Thanks. |
|
It was simpler to write the test. Added. |
This was referenced Oct 11, 2023
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2023
For example, OCDS `parties/details` is nullable, and additional codes for `parties/details/scale` were unreported. #131
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2023
For example, OCDS `parties/details` is nullable, and additional codes for `parties/details/scale` were unreported. #131
|
Moved to #139 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, OCDS
parties/detailsis nullable, and additional codes forparties/details/scalewere being reported in the "Other" section rather than the "Codelist Errors" section (sinceadd_is_codelistdidn't descend correctly).