Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use error_prefix is available (for 360Giving error grouping) #11

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Use error_prefix is available (for 360Giving error grouping) #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [0.3.0] - 2019-01-07
## [Unreleased]

### Added
### Changed

- Use error_prefix in validaiton error modal IDs, if available (for 360Giving error grouping) https://github.com/OpenDataServices/cove/issues/1117

## [0.3.0] - 2019-01-07

### Added

Expand Down
4 changes: 4 additions & 0 deletions cove/templates/validation_table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ <h4>{{ error.schema_title }}</h4>
{% endif %}
<td class="text-center">
{% if values|length > 3 %}
{% if error_prefix %}
<a data-toggle="modal" data-target=".{{"validation-errors-"|concat:error_prefix|concat:forloop.counter}}">
{% else %}
<a data-toggle="modal" data-target=".{{"validation-errors-"|concat:forloop.counter}}">
{% endif %}
{{values|length}}
</a>
{% else %}
Expand Down