Skip to content

Commit

Permalink
Merge pull request #11 from OpenDataServices/cove-1117-group-validation
Browse files Browse the repository at this point in the history
Use error_prefix is available (for 360Giving error grouping)
  • Loading branch information
Bjwebb authored Mar 1, 2019
2 parents 773a607 + e1cbc4b commit 1489d3d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [0.3.0] - 2019-01-07
## [Unreleased]

### Added
### Changed

- Use error_prefix in validaiton error modal IDs, if available (for 360Giving error grouping) https://github.com/OpenDataServices/cove/issues/1117

## [0.3.0] - 2019-01-07

### Added

Expand Down
4 changes: 4 additions & 0 deletions cove/templates/validation_table.html
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ <h4>{{ error.schema_title }}</h4>
{% endif %}
<td class="text-center">
{% if values|length > 3 %}
{% if error_prefix %}
<a data-toggle="modal" data-target=".{{"validation-errors-"|concat:error_prefix|concat:forloop.counter}}">
{% else %}
<a data-toggle="modal" data-target=".{{"validation-errors-"|concat:forloop.counter}}">
{% endif %}
{{values|length}}
</a>
{% else %}
Expand Down

0 comments on commit 1489d3d

Please sign in to comment.