Maintenance: Security updates #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MKodde
commented
Sep 20, 2023
•
MKodde
commented
- Yarn & Composer updates installed
- Upgraded Webpack Encore from v1 to 4
And ran composer bump to also update the composer.json package version to reflect the actually installed package versions.
|
The security updates are now breaking the unit and accpetance tests I've investigated on my dev env and the following things are in the way:
I feel OK to move forward with this, and tag it pre-release for now. We are about to overhaul this project and upgrade it to SF 5/6. So putting in this work now seems illogical. |
phavekes
reviewed
Sep 20, 2023
webpack.config.js
Outdated
| .addLoader({ test: /\.scss$/, loader: 'import-glob-loader' }) | ||
| .addLoader({test: /\.scss$/, loader: 'webpack-import-glob-loader'}) | ||
| .configureLoaderRule('eslint', loaderRule => { | ||
| loaderRule.test = /\.(jsx?|vue)$/ |
There was a problem hiding this comment.
Thanks for pointing this out.
To answer your question. This loads eslint and configures it to mark jsx and vue files a test resources
And that is completely out of scope for this project. Removed this loader.
FYI This code came from another stepup project where we already upgraded to Encore 4. So I yanked some of the updated config from there. But kept a bit too much 😊
phavekes
reviewed
Sep 20, 2023
package.json
Outdated
| "compass-mixins": "^0.12.10", | ||
| "@babel/core": "^7.20.5", | ||
| "@babel/preset-env": "^7.20.2", | ||
| "@symfony/webpack-encore": "^4", "compass-mixins": "^0.12.10", |
MKodde
force-pushed
the
maintenance/security-updates
branch
2 times, most recently
from
8957d69 to
d5c7194
Compare
MKodde
force-pushed
the
maintenance/security-updates
branch
from
d5c7194 to
b72de0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.