Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] correctly display observable types in filters list (#9857) #9901

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Archidoit
Copy link
Member

Proposed changes

In filters of type 'main observable type', the list of possible values should be observables types that are:

  • translated
  • with correct icon before

Related issues

#9857

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Feb 10, 2025
@Archidoit Archidoit self-assigned this Feb 10, 2025
@Archidoit Archidoit linked an issue Feb 10, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.29%. Comparing base (a4db997) to head (c95604a).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9901      +/-   ##
==========================================
+ Coverage   64.27%   64.29%   +0.01%     
==========================================
  Files         655      655              
  Lines       62933    62933              
  Branches     6960     6967       +7     
==========================================
+ Hits        40453    40460       +7     
+ Misses      22480    22473       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit merged commit 0904508 into master Feb 12, 2025
9 checks passed
@Archidoit Archidoit deleted the issue/9857 branch February 12, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity types are not translated in 'main observable type' filter
3 participants