Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF export of content in HTML is not working anymore #6773

Closed
SamuelHassine opened this issue Apr 19, 2024 · 7 comments · Fixed by #7339
Closed

PDF export of content in HTML is not working anymore #6773

SamuelHassine opened this issue Apr 19, 2024 · 7 comments · Fixed by #7339
Assignees
Labels
bug use for describing something not working as expected export Functional scope : EXPORT solved use to identify issue that has been solved (must be linked to the solving PR)

Comments

@SamuelHassine
Copy link
Member

Description

PDF export of content in HTML is not working anymore.

  1. Go to https://filigran.octi.filigran.io/dashboard/analyses/reports/39c5dfd8-aa33-4ada-ac62-cc405ad0d821/content?
  2. Click on PDF in the bottom bar

=> Nothing happens.

(same with all type of content / even just one word).

@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Apr 19, 2024
@SamuelHassine SamuelHassine added this to the Release 6.1.1 milestone Apr 19, 2024
@SamuelHassine SamuelHassine removed the needs triage use to identify issue needing triage from Filigran Product team label Apr 20, 2024
@CelineSebe
Copy link
Member

No issue in the local environment, tested

@lndrtrbn lndrtrbn self-assigned this May 21, 2024
@lndrtrbn lndrtrbn modified the milestones: Bugs backlog, Release 6.2.0 May 21, 2024
@lndrtrbn
Copy link
Member

Can reproduce by exporting the file in the link and uploading it locally. I take the issue

@lndrtrbn
Copy link
Member

Issue: applying an other font than Default breaks the PDF export

@lndrtrbn
Copy link
Member

Did the possibility to change fonts work at some point in the past?
We do not have those fonts defined anywhere in our static files so pdfmake cannot use them.
We have them because available in the editor because of some default CKEditor config I guess but to make the PDF export working we need to specify how to fetch them.

Should be fixable by:

  • adding manually those fonts in our static folder aside our Roboto fonts,
  • maybe link fonts resources used by CKEditor in node_modules but not sure it will work.

Does the possibility to change fonts is necessary? Easy fix: remove the font family button from editor.

@lndrtrbn lndrtrbn added the needs more info Intel needed about the use case label May 21, 2024
@nino-filigran
Copy link

@lndrtrbn are you expecting any answer from anybody on this ticket?

@lndrtrbn
Copy link
Member

lndrtrbn commented Jun 4, 2024

Well yes 😂

@lndrtrbn
Copy link
Member

lndrtrbn commented Jun 6, 2024

From discussions:

  • disabling the button to change the font family is not a solution as we can copy paste anything so even without the buttons to change font family we could still copy paste custom font
  • so still manage fonts in content editor. In export, ideally use the font if recognize otherwise use default, but if not possible use default font anytime

@lndrtrbn lndrtrbn removed the needs more info Intel needed about the use case label Jun 6, 2024
@Kedae Kedae added the export Functional scope : EXPORT label Jun 11, 2024
@lndrtrbn lndrtrbn linked a pull request Jun 11, 2024 that will close this issue
5 tasks
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected export Functional scope : EXPORT solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants