Remove Masking in Desktop mode #895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing is done: 1. We must be able to click through annotations. 2. We must be able to click on the palettes. Both will be implemented in other commits.
…inimized. That makes sense, because we cannot do anything, either.
… our help. This is why they are grouped and checkable.
2. In desktop mode, the palette works now. 3. Reverted the commit that removed the code for the manual checking of the icons in the desktop palette as that does not work reliably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the problem that you cannot click through the board in desktop mode. For me it works now. But I can only test it on X11 Linux. All this is very platform dependent. Someone must test this on Windows, Wayland Linux and MacOS, with Qt6, in the presenter mode and carefully review my changes. I think, my commit is quite a risky thing. So I don't know if and how you developers prefer to change such things. At some time this thing must be fixed.
Honestly I would recommend you to make the floating palettes not children of the board, before accepting my commit. Because in the current way, there happen too many things, which we don't have fully under control. The floating palettes disappear or become irresponsive together with the board. But you never want that. And you also don't want such a complicated masking mechanism. My solution is that the palette becomes a Qt-Window temporarily, but leaving the parent in. That works currently. But I would not be surprised if in future Qt versions this cheat stops working.