refactor: Remove usage of QT_IMPLICIT_QCHAR_CONSTRUCTION #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro `QT_IMPLICIT_QCHAR_CONSTRUCTION` allows converting an integer into a QChar. Starting with 6.0, the default behaviour of Qt is to only allow constructing a QChar from an integer explicitly, but until 6.8, above macro allowed the implicit conversion. Qt 6.8 removes the macro, requiring explicitly calling a QChar constructor when creating a QChar from an integer.
The macro `QT_IMPLICIT_QCHAR_CONSTRUCTION` allows converting an integer into a QChar. Starting with 6.0, the default behaviour of Qt is to only allow constructing a QChar from an integer explicitly, but until 6.8, above macro allowed the implicit conversion. Qt 6.8 removes the macro, requiring explicitly calling a QChar constructor when creating a QChar from an integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Qt 6.0, the macro
QT_IMPLICIT_QCHAR_CONSTRUCTIONwas necessary to allow implicit conversion frominttoQChar. Qt 6.8 removes this macro, making the default behaviour mandatory, i.e. call theQCharconstructor with anintto get aQChar.This affects Linux and Windows who make use of this macro; removing the macro reverts to the default since 6.0, so this change is fully backwards compatible.
Qt5 never had the macro (it was introduced to ease the transition from Qt5 to Qt6), therefore nothing changes there either.
Tested on Arch Linux with Qt 6.7.2, 6.8beta3, and 5.15.14.
Fixes #1055