Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MD5 hashing from UBFileSystemUtils #1019

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Vekhir
Copy link
Contributor

@Vekhir Vekhir commented Jun 18, 2024

The functions MD5_Init, MD5_Update, MD5_Final are deprecated in OpenSSL 3.0. This leads to warnings during compilation.

Use EVP_Q_digest instead.
Edit: Since the utility functions md5 and md5InHex are not used anywhere, just remove them.

@letsfindaway
Copy link
Collaborator

I have another proposal: The MD5 functions can safely be removed from UBFileSystemUtils as nobody is using them. And if there would be some future use, then QCryptographicHash already provides all this functionality.

@Vekhir
Copy link
Contributor Author

Vekhir commented Jun 19, 2024

True. I've checked out how the widgets sums are calculated and they use QCryptographicHash.

I've updated the commit to just remove those functions.

@letsfindaway
Copy link
Collaborator

Please remove them also from the header file.

OpenSSL 3.0 deprecates the low-level crypto functions leading to warnings.
@Vekhir Vekhir changed the title Refactor MD5 hashing to remove warnings with OpenSSL 3.0 Remove MD5 hashing from UBFileSystemUtils Jun 19, 2024
@Vekhir
Copy link
Contributor Author

Vekhir commented Jun 19, 2024

Done

@kaamui kaamui merged commit 1f1dce2 into OpenBoard-org:dev Aug 13, 2024
@Vekhir Vekhir deleted the refactor-md5 branch August 13, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants