Improve resync manager to better track unfunded addresses #1660

cpacia · 2019-07-23T20:27:34Z

Refactors the resync manager so that it:

loads all unfunded sales and purchases from the db
adds each payment address as a watch address so as to ensure we are watching
triggers the multiwallet to rescan for all unfunded order addresses

This also adds a migration to drop the needsSync column from the sales table as it's no longer used.

Remove the marking of an unfunded order as needsResync=false if a single resync has been performed. Since we use API wallets now the resync can be done much more frequently.

coveralls · 2019-07-23T20:36:08Z

Coverage increased (+0.08%) to 38.187% when pulling afdde10 on resync into 5c18158 on master.

placer14

Looks good overall. A few oversights to fix. I would also like to have errors and logs lead with the lower case char as well.

repo/db/purchases_test.go

repo/db/purchases.go

repo/db/purchases_test.go

repo/db/sales.go

repo/db/sales_test.go

wallet/resync/resync_manager.go

Conflicts: repo/migration.go repo/init.go

placer14

Remaining fixes are in. This looks GTM. Thanks.

Patch resync manager

c30ccc0

Remove the marking of an unfunded order as needsResync=false if a single resync has been performed. Since we use API wallets now the resync can be done much more frequently.

cpacia added 3 commits July 28, 2019 22:20

Refactor rescan manager and add migration024

ef18946

Set resync interval to 15 minutes

ac47b19

Fix bug initializing resyncManager

589ccef

cpacia added the needs confirmation label Jul 29, 2019

cpacia requested a review from placer14 July 29, 2019 15:40

drwasho added the 🔍 readyForReview Issue or PR ready for code review prior to closing. label Jul 30, 2019

drwasho assigned placer14 Jul 30, 2019

placer14 suggested changes Jul 31, 2019

View reviewed changes

drwasho added 🚧 in progress Issue or PR is currently being worked on and not in final form. and removed 🔍 readyForReview Issue or PR ready for code review prior to closing. needs confirmation labels Aug 1, 2019

Update unit tests and fix nits

91ef157

cpacia added 🔍 readyForReview Issue or PR ready for code review prior to closing. and removed 🚧 in progress Issue or PR is currently being worked on and not in final form. labels Aug 5, 2019

placer14 added 2 commits August 9, 2019 12:16

Move Migration024 to 025 for merge from master

9c95c2e

Merge branch 'master' into resync

afdde10

Conflicts: repo/migration.go repo/init.go

placer14 force-pushed the resync branch from 4e0416d to afdde10 Compare August 9, 2019 16:18

placer14 approved these changes Aug 9, 2019

View reviewed changes

placer14 merged commit 8a436d4 into master Aug 9, 2019

placer14 deleted the resync branch August 9, 2019 16:54

placer14 changed the title ~~Patch resync manager~~ Improve resync manager to better track unfunded addresses Aug 20, 2019

placer14 removed the 🔍 readyForReview Issue or PR ready for code review prior to closing. label Oct 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve resync manager to better track unfunded addresses #1660

Improve resync manager to better track unfunded addresses #1660

cpacia commented Jul 23, 2019 •

edited

Loading

coveralls commented Jul 23, 2019 •

edited

Loading

placer14 left a comment

placer14 left a comment

Improve resync manager to better track unfunded addresses #1660

Improve resync manager to better track unfunded addresses #1660

Conversation

cpacia commented Jul 23, 2019 • edited Loading

coveralls commented Jul 23, 2019 • edited Loading

placer14 left a comment

Choose a reason for hiding this comment

placer14 left a comment

Choose a reason for hiding this comment

cpacia commented Jul 23, 2019 •

edited

Loading

coveralls commented Jul 23, 2019 •

edited

Loading