Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

GET /ob/resolveipns/:peerid can perform self-lookups #1629

Merged
merged 5 commits into from
Jun 13, 2019

Conversation

placer14
Copy link
Member

@placer14 placer14 commented Jun 10, 2019

Closes #1601

@placer14 placer14 added the feature Feature or enhancement to openbazaar-go label Jun 10, 2019
@placer14 placer14 requested review from tyler-smith and cpacia June 10, 2019 16:44
@placer14 placer14 force-pushed the 1601-ipns-self-resolve branch from ba937fd to 3d84e0b Compare June 11, 2019 16:23
@placer14 placer14 marked this pull request as ready for review June 11, 2019 16:40
@coveralls
Copy link

coveralls commented Jun 11, 2019

Coverage Status

Coverage decreased (-0.06%) to 35.653% when pulling cc6b44f on 1601-ipns-self-resolve into 7945d11 on master.

@placer14 placer14 force-pushed the 1601-ipns-self-resolve branch from 1c186eb to 388fa7c Compare June 11, 2019 17:19
@cpacia
Copy link
Member

cpacia commented Jun 11, 2019

Do you want to try it with the SanitizedResponse?

Since we're using a JSON struct again, the sanitization can be safely
applied without truncating data.
@placer14 placer14 changed the title First attempt at IPNS self-lookup GET /ob/resolveipns/:peerid can perform self-lookups Jun 11, 2019
@placer14
Copy link
Member Author

@drwasho observes that the request doesn't work when you omit the peerID as an argument in the URL. Fixing to allow an empty request to assume you want your own IPNS record...

@placer14 placer14 force-pushed the 1601-ipns-self-resolve branch from 561fbbb to cc6b44f Compare June 12, 2019 21:14
@placer14 placer14 merged commit ef06d07 into master Jun 13, 2019
@placer14 placer14 deleted the 1601-ipns-self-resolve branch June 13, 2019 01:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature or enhancement to openbazaar-go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET /ob/resolveipns/:peerID should use own peerID if an argument is not passed
3 participants