This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Create and use repo.APITime to guarantee timestamp formatting in API #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - extract chat models into repo/chat_message.go - make repo.APITime a struct that embeds a time to get free access to time.Time methods
cpacia
approved these changes
May 22, 2019
placer14
force-pushed
the
1571-update-timestamp
branch
from
a548d42 to
536b37a
Compare
|
Small documentation included in OpenBazaar/official_docs#10 and validated Existing postman docs show accurate representations of timestamps. Update PR to include missing endpoints. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to guarantee the formatting and marshaling of timestamp formats, I created
repo.APITimeto protect inputs matchingtime.RFC3339andtime.RFC3339Nanoformats while also having a pattern to follow for future flexibility around time presentation in our JSON API.Closes #1571