This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Configure ipfs global vars in mobile package #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placer14
suggested changes
May 15, 2019
This was referenced May 15, 2019
|
I can change it but in general I'm not a fan of different packages for tests. This one doesn't need to test a private field yet, but it may in the future. |
|
General rule when testing: if you need to reach into the internals of the object to validate something, that's probably an indication that the object wasn't designed very well and is highly dependent on other objects. Making our unit testing easier is a lot about keeping dependency chains short. |
placer14
approved these changes
May 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1570