Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Squelch MODERATOR_ADD and MODERATOR_REMOVE notifications #1645

Closed
placer14 opened this issue Jun 24, 2019 · 1 comment · Fixed by #1637
Closed

Squelch MODERATOR_ADD and MODERATOR_REMOVE notifications #1645

placer14 opened this issue Jun 24, 2019 · 1 comment · Fixed by #1637
Assignees
@placer14
Labels
feature Feature or enhancement to openbazaar-go

Comments

@placer14
Copy link
Member

In order to removed the noise of notifications from stores adding/removing moderators from their store, the go daemon should prevent moderator node from seeing notifications from stores when adding and removing the node as a moderator for their store.
@placer14 placer14 added the feature Feature or enhancement to openbazaar-go label Jun 24, 2019
@placer14 placer14 self-assigned this Jun 24, 2019
placer14 added a commit that referenced this issue Jun 24, 2019
@placer14
[#1645] Prevent notifications produced on MODERATOR_ADD and REMOVE
5d23c06
@placer14 placer14 mentioned this issue Jun 24, 2019
Merged
placer14 added a commit that referenced this issue Jun 27, 2019
@placer14
[#1645] Prevent notifications produced on MODERATOR_ADD and REMOVE
5052f0c
placer14 added a commit that referenced this issue Jul 8, 2019
@placer14
Merge pull request #1646 from OpenBazaar/1645-squelch-mod-notification
29bbd0f 
[#1645] Prevent notifications produced on MODERATOR_ADD and REMOVE
@placer14
Copy link
Member Author

This is being merged into v2.3.4. Closing as resolved.

@placer14 placer14 mentioned this issue Jul 10, 2019
Merged
anchaj added a commit to phoreproject/pm-go that referenced this issue Aug 1, 2019
@anchaj
Merge commit 'v0.13.4' into development
604ba54 
* commit '08efac8c4ddd6a961b68976537ac8c10cac2399b':
  Handle error when calculating SHA peer id
  [OpenBazaar#1645] Prevent notifications produced on MODERATOR_ADD and REMOVE
anchaj added a commit to phoreproject/pm-go that referenced this issue Aug 8, 2019
@anchaj
Merge branch 'development' into pre-release
c8fee82 
* development: (77 commits)
  Fix imports.
  Remove unused gx code.
  Delete unused code.
  Purge unused packages.
  Add missing gx packages.
  Handle error when calculating SHA peer id
  [OpenBazaar#1645] Prevent notifications produced on MODERATOR_ADD and REMOVE
  Bump version to 0.13.4
  [OpenBazaar#1626] Fix secio handshake to properly fallback to alt ID generation
  [OpenBazaar#1634] Apply patch from go-libp2p-secio v0.0.3 release
  [OpenBazaar#1593] Add Start subcommand option to force key purge from IPNS cache
  Use separate namespace for IPNS persistent cache
  Best effort delete ipns record if unmarshaling fails
  Don't cache records for our own peerID
  Add validator in mobile package
  Add record validator to APIRouter
  [OpenBazaar#1557] Make CachingRouter implement routing.PubKeyFetcher
  [OpenBazaar#1557] CachingRouter network lookup fixes
  Cleanup function naming, lint failures
  Update mobile/node to use extracted config methods
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@placer14 placer14

Labels
feature Feature or enhancement to openbazaar-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge fixes from v0.13.4 OpenBazaar/openbazaar-go
1 participant
@placer14