Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Failed #5

Closed
mzwing opened this issue May 24, 2024 · 3 comments
Closed

Build Failed #5

mzwing opened this issue May 24, 2024 · 3 comments
Labels

Comments

@mzwing
Copy link

mzwing commented May 24, 2024

When I tried to build it, I got some strange errors...

Log here: https://github.com/MZWNET/actions/actions/runs/9226425626/job/25386167551

@tc-mb
Copy link
Collaborator

tc-mb commented May 25, 2024

When I tried to build it, I got some strange errors...

Log here: https://github.com/MZWNET/actions/actions/runs/9226425626/job/25386167551

Can you try to "make" under the environment or send me the environment you use?

tc-mb pushed a commit that referenced this issue May 28, 2024
* main : don't print special tokens with --grammar

The CLI interface was recently changed to print special control tokens
like the </s> stop message one. This token shouldn't be printed if the
grammar flag was passed, unless the grammar specifies it, because that
breaks shell-scriptability.

* main: use seperate stream for control characters

* main: use dprintf and add --ctrl-token-no-out and --ctrl-token-fd-out

* main: dprintf isn't part of the IEEE POSIX standard. Just use write().

* main: remove --ctrl-token-fd-out in favor for fcntl() based detection

* common.cpp: accidentally removed --interactive-first

* main: only merge stdout and control token if not in conversation or grammar mode

* main: rejig control token descriptor handling

* main: must check pipe status on very top of program

* main: renamed --no-special from  --ctrl-token-no-out and other refactoring

* main: refactor ctrl_token_no_out --> no_special

* llama: rename llama_token_is_control_token() to llama_token_is_control()

* main: remove special token file descriptor feature (#5)

---------

Co-authored-by: Brian <[email protected]>
@mzwing
Copy link
Author

mzwing commented May 30, 2024

Can you try to "make" under the environment or send me the environment you use?

Thanks for your reply, and sorry for my late.

You can easily find my action file at https://github.com/MZWNET/actions/blob/master/.github/workflows/llama_cpp_minicpm_v2.5.yml.

BTW I notice that my original llama.cpp build also encountered build error, so it should not be the repo's fault.

@github-actions github-actions bot added the stale label Jun 30, 2024
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants