Update display about make_env_init to install needed nodejs env #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe add github actions to test like install on win/linux/mac ? |
|
Yes, I think using github actions is a good way to test, too. |
Umpire2018
reviewed
Feb 23, 2024
| chmod +x ./scripts/install-nodejs.sh | ||
| ./scripts/install-nodejs.sh | ||
| chmod +x ./scripts/install_nodejs.sh | ||
| ./scripts/install_nodejs.sh |
There was a problem hiding this comment.
这个改动个人觉得没有必要，因为习惯是在终端使用 - 如 install-nodejs, 习惯在 python 中使用 _ 如 install_nodejs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mac is ok