[frontend] Fix warnings and fix linter #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #915 +/- ##
============================================
+ Coverage 25.87% 26.17% +0.30%
- Complexity 969 973 +4
============================================
Files 439 439
Lines 10126 10130 +4
Branches 482 482
============================================
+ Hits 2620 2652 +32
+ Misses 7444 7416 -28
Partials 62 62 ☔ View full report in Codecov by Sentry. |
|
|
guillaumejparis
force-pushed
the
bugfix/fix_warnings
branch
from
c15b0b4 to
8d486d5
Compare
guillaumejparis
force-pushed
the
bugfix/fix_warnings
branch
from
2be80d4 to
4c4188c
Compare
RomuDeuxfois
requested changes
May 29, 2024
| @@ -104,7 +107,7 @@ const InjectList: FunctionComponent<Props> = ({ | |||
| value: (injectDto: InjectResultDTO) => injectDto.inject_title, | |||
| }, | |||
| { | |||
| field: 'inject_status', | |||
| field: 'inject_status.tracking_sent_date', | |||
There was a problem hiding this comment.
This filter is not working
We need to modify the back-end for that
| @@ -118,7 +121,7 @@ const InjectList: FunctionComponent<Props> = ({ | |||
| }, | |||
| }, | |||
| { | |||
| field: 'inject_status', | |||
| field: 'inject_status.status_name', | |||
There was a problem hiding this comment.
This filter is not working
We need to modify the back-end for that
RomuDeuxfois
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.