Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend]Fix users list header #873

Merged
merged 3 commits into from
May 17, 2024
Merged

[frontend]Fix users list header #873

merged 3 commits into from
May 17, 2024

Conversation

johanah29
Copy link
Member

@johanah29 johanah29 commented May 15, 2024

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.85%. Comparing base (2a7bfc4) to head (50fca45).
Report is 17 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #873      +/-   ##
============================================
- Coverage     26.97%   26.85%   -0.12%     
- Complexity      913      914       +1     
============================================
  Files           410      410              
  Lines          9280     9339      +59     
  Branches        431      439       +8     
============================================
+ Hits           2503     2508       +5     
- Misses         6717     6771      +54     
  Partials         60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johanah29 johanah29 marked this pull request as ready for review May 15, 2024 12:19
@RomuDeuxfois
Copy link
Member

what is the purpose of this fix?
If the goal is to center the admin icon, we have to think about what else you want to center: the headers, ect.
My concern is about adding a padding instead of have a generic flex class

@johanah29 johanah29 dismissed RomuDeuxfois’s stale review May 17, 2024 10:21

Review adressed

@johanah29 johanah29 self-assigned this May 17, 2024
@RomuDeuxfois RomuDeuxfois merged commit 736ec12 into master May 17, 2024
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the bugfix/users-list branch May 17, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In list of users (settings), tags header is missing
2 participants