Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I create a technical inject in a simulation and I remove the expectation, expectations still there #2387

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois changed the base branch from master to release/current February 6, 2025 15:08
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 58.82353% with 35 lines in your changes missing coverage. Please review.

Project coverage is 38.29%. Comparing base (6586865) to head (e68cf83).
Report is 1 commits behind head on release/current.

Files with missing lines Patch % Lines
.../io/openbas/rest/inject/service/InjectService.java 64.91% 15 Missing and 5 partials ⚠️
...penbas/rest/inject/form/InjectDependencyInput.java 0.00% 6 Missing ⚠️
.../openbas/rest/inject/form/InjectDocumentInput.java 0.00% 5 Missing ⚠️
...java/io/openbas/rest/document/DocumentService.java 0.00% 3 Missing ⚠️
...main/java/io/openbas/utils/AtomicTestingUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2387      +/-   ##
=====================================================
- Coverage              38.41%   38.29%   -0.13%     
+ Complexity              1816     1815       -1     
=====================================================
  Files                    598      600       +2     
  Lines                  18410    18314      -96     
  Branches                1232     1218      -14     
=====================================================
- Hits                    7073     7013      -60     
+ Misses                 10947    10925      -22     
+ Partials                 390      376      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@johanah29 johanah29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests OK

@RomuDeuxfois RomuDeuxfois marked this pull request as draft February 7, 2025 09:26
@RomuDeuxfois RomuDeuxfois marked this pull request as ready for review February 12, 2025 15:37
@RomuDeuxfois RomuDeuxfois merged commit 0e09d9a into release/current Feb 13, 2025
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/2316 branch February 13, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants