Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Build payloadOutput for Caldera injects #2360

Merged
merged 15 commits into from
Feb 5, 2025

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Feb 3, 2025

Proposed changes

  • Complete info for injects from other sources (caldera, ..): name, description, command...
  • Filter page paylaod detail for injects type channel, challenge
  • Clean ui InjectTests (remove ack date, total count..)
  • Fix notification when an inject is tested: injectTitle was not displayed correctly
  • Remove legacy code for results on injectPopover

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

image
image

image

@savacano28 savacano28 self-assigned this Feb 3, 2025
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Feb 3, 2025
@savacano28 savacano28 changed the base branch from master to release/current February 3, 2025 17:33
@savacano28 savacano28 force-pushed the bugfix/2311 branch 2 times, most recently from 08fdfd6 to 7e397ec Compare February 4, 2025 15:08
@savacano28 savacano28 requested a review from johanah29 February 4, 2025 17:12
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 6.76692% with 124 lines in your changes missing coverage. Please review.

Project coverage is 37.93%. Comparing base (4951efa) to head (385a2cf).
Report is 6 commits behind head on release/current.

Files with missing lines Patch % Lines
.../src/main/java/io/openbas/utils/PayloadMapper.java 0.92% 107 Missing ⚠️
...pi/src/main/java/io/openbas/utils/InjectUtils.java 0.00% 14 Missing ⚠️
.../io/openbas/injectors/caldera/CalderaExecutor.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2360      +/-   ##
=====================================================
- Coverage              37.99%   37.93%   -0.06%     
- Complexity              1788     1790       +2     
=====================================================
  Files                    597      598       +1     
  Lines                  18349    18402      +53     
  Branches                1222     1214       -8     
=====================================================
+ Hits                    6971     6981      +10     
- Misses                 11008    11052      +44     
+ Partials                 370      369       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review February 5, 2025 08:01
@savacano28 savacano28 force-pushed the bugfix/2311 branch 2 times, most recently from 9cbace1 to d7959d0 Compare February 5, 2025 10:47
@johanah29
Copy link
Member

Tests ok

@savacano28 savacano28 merged commit ce06716 into release/current Feb 5, 2025
6 checks passed
@savacano28 savacano28 deleted the bugfix/2311 branch February 6, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I try to access the Payload info (atomic test) I get an internal error
2 participants