Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix Caldera agent with OpenBAS payload #2284

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

damgouj
Copy link
Member

@damgouj damgouj commented Jan 22, 2025

Proposed changes

  • Add agentId to execute an OpenBAS payload with a Caldera agent

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@damgouj damgouj self-assigned this Jan 22, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 22, 2025
@damgouj damgouj requested a review from MarineLeM January 22, 2025 10:12
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 32.77%. Comparing base (92e7aab) to head (6567eaa).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...caldera/service/CalderaExecutorContextService.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2284      +/-   ##
============================================
- Coverage     32.78%   32.77%   -0.01%     
  Complexity     1517     1517              
============================================
  Files           584      584              
  Lines         18008    18011       +3     
  Branches       1157     1157              
============================================
  Hits           5904     5904              
- Misses        11840    11843       +3     
  Partials        264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damgouj damgouj merged commit c049529 into master Jan 22, 2025
7 checks passed
@damgouj damgouj deleted the issue/2283 branch January 22, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject stays in pending for Caldera agent and OpenBAS payload
3 participants