Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Add tests for importing Simulation (JSON) (#1489) #2219

Merged
merged 19 commits into from
Jan 24, 2025

Conversation

antoinemzs
Copy link
Contributor

Proposed changes

  • Add tests for importing Simulation in JSON

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@antoinemzs antoinemzs changed the base branch from master to issue/1489_tests January 15, 2025 15:58
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 35.91%. Comparing base (13d6e1b) to head (7f6d974).
Report is 32 commits behind head on release/current.

Files with missing lines Patch % Lines
...rc/main/java/io/openbas/rest/mapper/MapperApi.java 0.00% 4 Missing ⚠️
...main/java/io/openbas/importer/V1_DataImporter.java 72.72% 3 Missing ⚠️
...o/openbas/rest/exercise/service/ExportService.java 93.47% 2 Missing and 1 partial ⚠️
...rc/main/java/io/openbas/service/MapperService.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2219      +/-   ##
=====================================================
+ Coverage              33.73%   35.91%   +2.17%     
- Complexity              1566     1704     +138     
=====================================================
  Files                    583      587       +4     
  Lines                  18000    18481     +481     
  Branches                1168     1239      +71     
=====================================================
+ Hits                    6072     6637     +565     
+ Misses                 11635    11519     -116     
- Partials                 293      325      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from issue/1489_tests to release/current January 20, 2025 13:42
@antoinemzs antoinemzs force-pushed the issue/1489_import_json branch from cd7cf52 to 06e4870 Compare January 20, 2025 13:59
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs force-pushed the issue/1489_import_json branch from 29be0d5 to 5cf5ed8 Compare January 20, 2025 14:32
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs marked this pull request as ready for review January 21, 2025 16:34
Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs merged commit 7dc05ee into release/current Jan 24, 2025
6 checks passed
@antoinemzs antoinemzs deleted the issue/1489_import_json branch January 24, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Unit testing - simulation scope ] - import/export of a simulation (JSON)
2 participants