[backend] Fix on deleted injector contract #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
filigran team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2204 +/- ##
============================================
+ Coverage 32.66% 32.69% +0.02%
- Complexity 1511 1513 +2
============================================
Files 581 582 +1
Lines 18026 18033 +7
Branches 1156 1156
============================================
+ Hits 5889 5896 +7
Misses 11874 11874
Partials 263 263 ☔ View full report in Codecov by Sentry. |
savacano28
previously approved these changes
Jan 13, 2025
| Statement statement = connection.createStatement(); | ||
|
|
||
| statement.execute( | ||
| "ALTER TABLE inject_importers alter column importer_mapper_id drop not null;"); |
There was a problem hiding this comment.
The column name is different in SQL side and Java side
RomuDeuxfois
approved these changes
Jan 14, 2025
savacano28
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...