-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Add the default Assets logic to scenario creation and update #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.11.0 #2161 +/- ##
====================================================
- Coverage 36.56% 33.26% -3.30%
+ Complexity 1505 1400 -105
====================================================
Files 546 546
Lines 16630 16707 +77
Branches 1061 1062 +1
====================================================
- Hits 6080 5558 -522
- Misses 10241 10919 +678
+ Partials 309 230 -79 ☔ View full report in Codecov by Sentry. |
RomuDeuxfois
reviewed
Jan 7, 2025
openbas-api/src/test/java/io/openbas/utils/fixtures/ScenarioFixture.java
Outdated
Show resolved
Hide resolved
openbas-api/src/test/java/io/openbas/utils/fixtures/AssetFixture.java
Outdated
Show resolved
Hide resolved
openbas-api/src/test/java/io/openbas/utils/fixtures/ExerciseFixture.java
Outdated
Show resolved
Hide resolved
RomuDeuxfois
reviewed
Jan 7, 2025
RomuDeuxfois
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
-> I didn't not add api tests as I was struggling to make them work, it will be added in a follow up PR
Related issues
Checklist