[Backend]Test teams creation/update (#1491) #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.11.0 #2149 +/- ##
====================================================
+ Coverage 36.56% 36.86% +0.30%
- Complexity 1505 1526 +21
====================================================
Files 546 546
Lines 16630 16630
Branches 1061 1061
====================================================
+ Hits 6080 6131 +51
+ Misses 10241 10183 -58
- Partials 309 316 +7 ☔ View full report in Codecov by Sentry. |
|
Can you take care of upsertTeam as well ? thx |
antoinemzs
reviewed
Jan 6, 2025
| @@ -2,25 +2,32 @@ | |||
|
|
|||
There was a problem hiding this comment.
Can't comment on the correct lines: good to inherit from our IntegrationTests class to benefit from free annotations (further consolidating common behaviour in e2e endpoint tests)
There was a problem hiding this comment.
Make TeamApiTests @Transactional too? And remove cleanup calls.
|
Ready for a second round :) |
RomuDeuxfois
force-pushed
the
issue/1491
branch
from
15fc9ae to
e2f88da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1491