Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix on 500 errors when importing a scenario (#2144) #2146

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Jan 2, 2025

Proposed changes

  • Fix on 500 errors when importing a scenario

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.10%. Comparing base (05f9984) to head (4a25257).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...main/java/io/openbas/importer/V1_DataImporter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2146      +/-   ##
============================================
- Coverage     35.31%   35.10%   -0.21%     
+ Complexity     1429     1418      -11     
============================================
  Files           536      536              
  Lines         16195    16195              
  Branches       1036     1036              
============================================
- Hits           5719     5686      -33     
- Misses        10175    10215      +40     
+ Partials        301      294       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion merged commit 0f44a3e into master Jan 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Internal Server Error on import of scenario
3 participants