Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Fix password reset for users who are not logged in #2141

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Jan 2, 2025

Proposed changes

  • Fix password reset for users who are not logged in
  • Fix axios interceptor when response is empty
  • Add message for bad request
  • Improve message for current user not existent

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Jan 2, 2025
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Jan 2, 2025
@savacano28 savacano28 changed the base branch from master to release/1.11.0 January 2, 2025 08:12
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 36.09%. Comparing base (f257e8e) to head (3ae5bb2).
Report is 1 commits behind head on release/1.11.0.

Files with missing lines Patch % Lines
...main/java/io/openbas/rest/helper/RestBehavior.java 0.00% 15 Missing ⚠️
...-api/src/main/java/io/openbas/rest/user/MeApi.java 0.00% 9 Missing ⚠️
...ain/java/io/openbas/rest/document/DocumentApi.java 0.00% 4 Missing ⚠️
...ain/java/io/openbas/rest/exercise/ExerciseApi.java 0.00% 3 Missing ⚠️
...rc/main/java/io/openbas/rest/inject/InjectApi.java 60.00% 2 Missing ⚠️
...o/openbas/rest/objective/ExerciseObjectiveApi.java 0.00% 2 Missing ⚠️
...o/openbas/rest/objective/ScenarioObjectiveApi.java 0.00% 2 Missing ⚠️
...pi/src/main/java/io/openbas/rest/team/TeamApi.java 0.00% 2 Missing ⚠️
.../src/main/java/io/openbas/rest/user/PlayerApi.java 0.00% 2 Missing ⚠️
...c/main/java/io/openbas/service/MailingService.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.11.0    #2141      +/-   ##
====================================================
+ Coverage             36.00%   36.09%   +0.08%     
- Complexity             1479     1486       +7     
====================================================
  Files                   544      544              
  Lines                 16543    16572      +29     
  Branches               1056     1057       +1     
====================================================
+ Hits                   5957     5981      +24     
- Misses                10286    10288       +2     
- Partials                300      303       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review January 2, 2025 10:07
@heditar heditar self-requested a review January 3, 2025 09:51
@savacano28 savacano28 merged commit 3430fe2 into release/1.11.0 Jan 3, 2025
6 checks passed
@savacano28 savacano28 deleted the bugfix/1963 branch January 3, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"I forgot my password" returns internal error
2 participants