Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend/frontend] Adapt backend on new agent logic #2133

Merged
merged 18 commits into from
Jan 2, 2025
Merged

[backend/frontend] Adapt backend on new agent logic #2133

merged 18 commits into from
Jan 2, 2025

Conversation

isselparra
Copy link
Contributor

@isselparra isselparra commented Dec 30, 2024 •
edited by damgouj
Loading

Proposed changes

  • Adapt OpenBAS backend and frontend for the next tasks related to the agents (multi traces, installation mode,...)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Dec 30, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 27.11864% with 86 lines in your changes missing coverage. Please review.

Project coverage is 35.37%. Comparing base (35755b2) to head (b25d4fd).
Report is 2 commits behind head on release/1.11.0.

Files with missing lines Patch % Lines
...va/io/openbas/rest/asset/endpoint/EndpointApi.java 0.00% 32 Missing ⚠️
.../io/openbas/injectors/caldera/CalderaExecutor.java 0.00% 30 Missing ⚠️
.../io/openbas/migration/V3_54__Add_table_agents.java 42.85% 18 Missing and 2 partials ⚠️
...njectors/caldera/client/CalderaInjectorClient.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                  @@
##             release/1.11.0    #2133      +/-   ##
====================================================
+ Coverage             35.12%   35.37%   +0.25%     
- Complexity             1418     1424       +6     
====================================================
  Files                   536      537       +1     
  Lines                 16184    16272      +88     
  Branches               1036     1043       +7     
====================================================
+ Hits                   5684     5756      +72     
- Misses                10206    10220      +14     
- Partials                294      296       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isselparra isselparra changed the base branch from master to release/1.11.0 December 30, 2024 13:54
@damgouj damgouj changed the title Issue/2067 [backend/frontend] Adapt backend on new agent logic Dec 31, 2024
@damgouj damgouj self-assigned this Dec 31, 2024
@damgouj damgouj linked an issue Dec 31, 2024 that may be closed by this pull request
adapt backend on new agent logic #2067
Closed
@damgouj damgouj marked this pull request as ready for review December 31, 2024 10:20
RomuDeuxfois
RomuDeuxfois reviewed Dec 31, 2024
View reviewed changes
openbas-model/src/main/java/io/openbas/database/repository/EndpointRepository.java Outdated Show resolved Hide resolved
openbas-model/src/main/java/io/openbas/database/repository/EndpointRepository.java Outdated Show resolved Hide resolved
openbas-model/src/main/java/io/openbas/database/model/Agent.java Show resolved Hide resolved
openbas-model/src/main/java/io/openbas/database/model/Agent.java Show resolved Hide resolved
openbas-api/src/main/java/io/openbas/executors/caldera/service/CalderaExecutorService.java Outdated Show resolved Hide resolved
openbas-framework/src/main/java/io/openbas/executors/tanium/service/TaniumExecutorService.java Outdated Show resolved Hide resolved
openbas-framework/src/main/java/io/openbas/asset/AssetGroupService.java Outdated Show resolved Hide resolved
openbas-framework/src/main/java/io/openbas/asset/AssetGroupService.java Outdated Show resolved Hide resolved
openbas-framework/src/main/java/io/openbas/asset/AgentService.java Outdated Show resolved Hide resolved
openbas-api/src/test/resources/application.properties Show resolved Hide resolved
@damgouj
Copy link
Member

damgouj commented Dec 31, 2024

Thanks for your feedback and help ! Ready for a second review !

@damgouj damgouj requested a review from RomuDeuxfois December 31, 2024 16:22
RomuDeuxfois
RomuDeuxfois approved these changes Dec 31, 2024
View reviewed changes
openbas-front/src/actions/assets/asset-helper.d.ts

export interface EndpointHelper {
getEndpoints: () => Endpoint[];
getEndpointsMap: () => Record<string, Endpoint>;
}

export interface SecurityPlatformHelper {
getSecurityPlatforms: () => SecurityPlatformStore[];
getSecurityPlatformsMap: () => Record<string, SecurityPlatformStore>;
getSecurityPlatforms: () => SecurityPlatform[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@damgouj damgouj merged commit 53e2d0a into release/1.11.0 Jan 2, 2025
6 checks passed
@damgouj damgouj deleted the issue/2067 branch January 2, 2025 07:41
@damgouj damgouj restored the issue/2067 branch January 2, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damgouj damgouj damgouj left review comments

@RomuDeuxfois RomuDeuxfois RomuDeuxfois approved these changes

Assignees

@damgouj damgouj

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adapt backend on new agent logic
3 participants
@isselparra @damgouj @RomuDeuxfois