Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Fixing the card layout used to display the inject result Issue/1642 #2132

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

heditar
Copy link
Contributor

@heditar heditar commented Dec 27, 2024

Proposed changes

  • Fixing the card layout used to display the inject result so the the menu is visible

Before
Screenshot 2024-12-27 160344

After
Screenshot 2024-12-27 160328

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@heditar heditar added the filigran team use to identify PR from the Filigran team label Dec 27, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.11%. Comparing base (c1040ac) to head (ca60097).
Report is 4 commits behind head on release/1.11.0.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/1.11.0    #2132   +/-   ##
=================================================
  Coverage             35.11%   35.11%           
  Complexity             1418     1418           
=================================================
  Files                   535      535           
  Lines                 16187    16187           
  Branches               1037     1037           
=================================================
  Hits                   5684     5684           
  Misses                10209    10209           
  Partials                294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heditar heditar merged commit ea7f3b1 into release/1.11.0 Jan 2, 2025
6 checks passed
@heditar heditar deleted the issue/1642 branch January 2, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants